NeuronTestHelper: CORENEURON option, reorganise. #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create nrnivmodl targets in nrn_add_test_group and add a CORENEURON option to that command. This means that we do not have to compile *all* MOD files for CoreNEURON if CoreNEURON is enabled in the build. - Drop MODFILE_PATTERNS, NRNIVMODL_ARGS and SUBMODULE arguments to nrn_add_test that were not being used. - The same de-duplication is done as before, so there is no change to the number of nrnivmodl invocations, but some targets no longer pass -coreneuron to nrnivmodl.
Codecov Report
@@ Coverage Diff @@
## master #1768 +/- ##
==========================================
+ Coverage 45.42% 45.43% +0.01%
==========================================
Files 551 551
Lines 113149 113149
==========================================
+ Hits 51393 51405 +12
+ Misses 61756 61744 -12
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
pramodk
reviewed
Apr 6, 2022
BlueBrain/nmodl#311 has been closed, so hopefully these work now.
olupton
force-pushed
the
olupton/shuffle-tests
branch
from
dda1540
to
4289b45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrnivmodltargets innrn_add_test_groupand add aCORENEURONoption to that command. This means that we do not have to compile all MOD files for CoreNEURON if CoreNEURON is enabled in the build.MODFILE_PATTERNS,NRNIVMODL_ARGSandSUBMODULEarguments tonrn_add_testthat were not being used.nrnivmodlinvocations, but some targets no longer pass-coreneurontonrnivmodl.Motivated because I realised that the test framework was requiring that even MOD files for NEURON-only tests were compilable for CoreNEURON. This also speeds things up a little, as we skip some
nrnivmodl-coreinvocations.Also remove some test exclusions in
testcorenrnbecause the referenced issue (BlueBrain/nmodl#311) was closed. Hopefully they will work now; https://bbpgitlab.epfl.ch/hpc/coreneuron/-/pipelines/46658 should confirm.