Check if including mpi headers are required #1772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1772 +/- ##
==========================================
- Coverage 45.49% 45.45% -0.04%
==========================================
Files 551 551
Lines 113149 113149
==========================================
- Hits 51476 51431 -45
- Misses 61673 61718 +45
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
olupton
approved these changes
Apr 11, 2022
There was a problem hiding this comment.
LGTM, apart from one nitpick that this:
Line 831 in 415a69c
should be conditional on
NRN_INCLUDE_MPI_HEADERS
I checked in a macOS wheel from the CI that NRN_INCLUDE_MPI_HEADERS expands to OFF, but didn't test the other way around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1771