Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack hocdomain.py for Sphinx 5.0.1 #1851

Merged
merged 3 commits into from
Jun 16, 2022
Merged

hack hocdomain.py for Sphinx 5.0.1 #1851

merged 3 commits into from
Jun 16, 2022

Conversation

alexsavulescu
Copy link
Member

@alexsavulescu alexsavulescu commented Jun 16, 2022

Sphinx 5.0.1 is out:

Traceback (most recent call last):
  File "/home/docs/checkouts/readthedocs.org/user_builds/nrn/conda/latest/lib/python3.10/site-packages/sphinx/config.py", line 343, in eval_config_file
    exec(code, namespace)
  File "/home/docs/checkouts/readthedocs.org/user_builds/nrn/checkouts/latest/docs/conf.py", line 22, in <module>
    import hocdomain  # Sphinx HOC domain (hacked from the Python domain via docs/generate_hocdomain.py)
  File "/home/docs/checkouts/readthedocs.org/user_builds/nrn/checkouts/latest/docs/domains/hocdomain.py", line 41, in <module>
    from sphinx.deprecation import RemovedInSphinx50Warning, RemovedInSphinx60Warning
ImportError: cannot import name 'RemovedInSphinx50Warning' from 'sphinx.deprecation' (/home/docs/checkouts/readthedocs.org/user_builds/nrn/conda/latest/lib/python3.10/site-packages/sphinx/deprecation.py)

@alexsavulescu
Copy link
Member Author

RTD build successful: https://nrn.readthedocs.io/en/hocdomain501/

@azure-pipelines
Copy link

✔️ 646ba9e -> Azure artifacts URL

Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know how you figured some of this out :) Did you analyze the differences between old and new sphinx/domains/python.py ? Do you have debugging understanding that is teachable? There is a hackathon coming up ... :)

@alexsavulescu
Copy link
Member Author

@nrnhines it's all in the error log above :) import hocdomain # Sphinx HOC domain (hacked from the Python domain via docs/generate_hocdomain.py)

https://docs.google.com/presentation/d/19k5O9DjTTGffdq4nQEEzGZtYdL_0sZTFMARje7UUVPI/edit#slide=id.g10eed073d91_0_0

@alexsavulescu alexsavulescu merged commit 31862a2 into master Jun 16, 2022
@alexsavulescu alexsavulescu deleted the hocdomain501 branch June 16, 2022 11:27
@alexsavulescu
Copy link
Member Author

There is a hackathon coming up ... :)

I've created one ticket related to this

@alexsavulescu alexsavulescu mentioned this pull request Jun 29, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants