Remove more C++ transitional measures #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1903 +/- ##
==========================================
- Coverage 47.17% 47.13% -0.04%
==========================================
Files 543 543
Lines 112912 112910 -2
==========================================
- Hits 53264 53221 -43
- Misses 59648 59689 +41
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
✔️ 622aeb3 -> Azure artifacts URL |
|
✔️ b8e873c -> Azure artifacts URL |
Launched https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/2623246528 comparing this with |
Looks alright to me. |
olupton
added a commit
that referenced
this pull request
Jul 7, 2022
olupton
added a commit
that referenced
this pull request
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now #1597 is merged, only some quasi-external code like scopmath, sparse13 and mesch is still compiled as C.
This means that most explicit C linkage is no longer needed, and we can use C++ linkage. Similarly
__cpluspluscan be assumed to be defined in most cases.When things are being touched anyway, tend to prefer moving declarations to header files and including those headers:
oc_save_hoc_oopandoc_restore_hoc_oopwere being called with the wrong number of arguments.There are some exceptions:
dlopen,dlsymetc...so for the moment it's simpler to stick with C linkage.dlopenand friends, and keep C linkage.Some unused files were deleted:
src/nrnoc/cprop.cppsrc/oc/spinit.cppQuestions / deferred items: