Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop auto-formatting PRs. #3087

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Stop auto-formatting PRs. #3087

merged 1 commit into from
Sep 23, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Sep 23, 2024

Unfortunately, the auto-fromatting breaks running the CI. Leading to a workflow that requires pulling creating fake change and pushing again.

Formatting is handled by Tristan's nice tool:

./external/coding-conventions/bin/format

Unfortunately, the auto-fromatting breaks running the CI. Leading
to a workflow that requires pulling creating fake change and pushing
again.

Formatting is handled by Tristan's nice tool:

    ./external/coding-conventions/bin/format
@1uc 1uc linked an issue Sep 23, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented Sep 23, 2024

@1uc 1uc marked this pull request as ready for review September 23, 2024 14:37
Copy link

✔️ 1eb108c -> Azure artifacts URL

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.39%. Comparing base (5928676) to head (1eb108c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3087   +/-   ##
=======================================
  Coverage   67.39%   67.39%           
=======================================
  Files         573      573           
  Lines      104927   104927           
=======================================
  Hits        70716    70716           
  Misses      34211    34211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1uc 1uc merged commit 80a2c01 into master Sep 23, 2024
37 checks passed
@1uc 1uc deleted the 1uc/no-auto-format branch September 23, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic formatting fixup breaks CI.
3 participants