Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lexer for ONTOLOGY parsing #3091

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Fix lexer for ONTOLOGY parsing #3091

merged 4 commits into from
Sep 25, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Sep 24, 2024

Fix #175

src/nmodl/lex.lpp Outdated Show resolved Hide resolved
Copy link

✔️ 335bc74 -> Azure artifacts URL

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.85%. Comparing base (dc9d4c9) to head (d8d5640).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nmodl/lex.lpp 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3091      +/-   ##
==========================================
- Coverage   67.85%   67.85%   -0.01%     
==========================================
  Files         572      572              
  Lines      104205   104210       +5     
==========================================
+ Hits        70709    70710       +1     
- Misses      33496    33500       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pramodk pramodk changed the title Fix lexing of ontology Fix lexer for ONTOLOGY parsing Sep 24, 2024
@pramodk pramodk enabled auto-merge (squash) September 24, 2024 20:36
Copy link

sonarcloud bot commented Sep 24, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link

✔️ d8d5640 -> Azure artifacts URL

@pramodk pramodk merged commit 2bfcab3 into master Sep 25, 2024
37 checks passed
@pramodk pramodk deleted the cornu/lex_ontology branch September 25, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nrnivmodl allows unclosed safe CURIEs
2 participants