Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hines/ions tmp #3098

Closed
wants to merge 29 commits into from
Closed

Hines/ions tmp #3098

wants to merge 29 commits into from

Conversation

nrnhines
Copy link
Member

Same as #3081 to test if the ci coverage passes.

Copy link

✔️ 74d6029 -> Azure artifacts URL

@nrnhines
Copy link
Member Author

Fresh PR still gives the error for NEURON Code Coverage / Code Coverage (pull_request)

2024-09-27T00:34:26.0965656Z  88/355 Test  #88: hoctests::test_neurondemo_py .............................................***Failed    1.43 sec
2024-09-27T00:34:26.0967884Z stderr: libgcov profiling error:/home/runner/work/nrn/nrn/build/share/nrn/demo/release/x86_64/mod_func.gcda:overwriting an existing profile data with a different

Copy link

✔️ 1606e7d -> Azure artifacts URL

@nrnhines
Copy link
Member Author

Surprise, still get the error with Remove capmpr.mod from neurondemo and test_many_ions.py 1606e7d

88/355 Test  #88: hoctests::test_neurondemo_py .............................................***Failed

Note that test_many_ions.py still loads the mechanisms from neurondemo.

Copy link

✔️ 84ce3ca -> Azure artifacts URL

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.90%. Comparing base (93c7d2c) to head (0e90c82).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3098      +/-   ##
==========================================
- Coverage   67.86%   66.90%   -0.96%     
==========================================
  Files         572      572              
  Lines      104210   106671    +2461     
==========================================
+ Hits        70718    71368     +650     
- Misses      33492    35303    +1811     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nrnhines
Copy link
Member Author

nrnhines commented Sep 27, 2024

NEURON CI / macOS-12 - setuptools (CC=gcc-9 CXX=g++-9) (pull_request) Successful in 15m
with
quit() in test_many_ions.py before loading neurondemo library 84ce3ca

I wonder if the tests are run in parallel and test_neurondemo_py and test_many_ions_py are being run at the same time with distinct instances of build/share/nrn/demo/release/x86_64/libnrnmech.so that write to build/share/nrn/demo/release/x86_64/mod_func.gcda at the same time.

On my machine, bldcover$ ctest -j 8 -R hoctests does not fail.

Copy link

✔️ 88f571c -> Azure artifacts URL

Copy link

sonarcloud bot commented Sep 30, 2024

Copy link

✔️ 0e90c82 -> Azure artifacts URL

@nrnhines
Copy link
Member Author

We seem to have worked around the CI coverage test failure by serializing use of the neurondemo shared library. Ie. 0e90c82 copies the contents of test_many_ions.py to the end of test_neuron_demo.py and removes the former file.

@nrnhines nrnhines closed this Sep 30, 2024
@nrnhines
Copy link
Member Author

The substantive change associated with this PR has been squashed into #3081

@nrnhines nrnhines deleted the hines/ions-tmp branch September 30, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants