-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hines/ions tmp #3098
Hines/ions tmp #3098
Conversation
… for bitvector comparisons
Co-authored-by: Luc Grosheintz <[email protected]>
Co-authored-by: Luc Grosheintz <[email protected]>
Co-authored-by: Luc Grosheintz <[email protected]>
Co-authored-by: Luc Grosheintz <[email protected]>
✔️ 74d6029 -> Azure artifacts URL |
Fresh PR still gives the error for
|
✔️ 1606e7d -> Azure artifacts URL |
Surprise, still get the error with
Note that |
✔️ 84ce3ca -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3098 +/- ##
==========================================
- Coverage 67.86% 66.90% -0.96%
==========================================
Files 572 572
Lines 104210 106671 +2461
==========================================
+ Hits 70718 71368 +650
- Misses 33492 35303 +1811 ☔ View full report in Codecov by Sentry. |
I wonder if the tests are run in parallel and On my machine, |
This reverts commit 84ce3ca.
✔️ 88f571c -> Azure artifacts URL |
Quality Gate passedIssues Measures |
✔️ 0e90c82 -> Azure artifacts URL |
We seem to have worked around the CI coverage test failure by serializing use of the neurondemo shared library. Ie. 0e90c82 copies the contents of test_many_ions.py to the end of test_neuron_demo.py and removes the former file. |
The substantive change associated with this PR has been squashed into #3081 |
Same as #3081 to test if the ci coverage passes.