Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annex: Hide git-annex and synced/* branches #4

Open
kousu opened this issue May 8, 2022 · 3 comments
Open

annex: Hide git-annex and synced/* branches #4

kousu opened this issue May 8, 2022 · 3 comments

Comments

@kousu
Copy link
Member

kousu commented May 8, 2022

The 'git-annex' and 'synced/' branches should be special-cased so that they don't show up as pull request suggestions, either on the command line after a push or on the web UI.

Accidentally merging git-annex into main would be a disaster and we should prevent it.

gitea-sync bot pushed a commit that referenced this issue Jun 27, 2022
* Prototyping

* Start work on creating offsets

* Modify tests

* Start prototyping with actual MPH

* Twiddle around

* Twiddle around comments

* Convert templates

* Fix external languages

* Fix latest translation

* Fix some test

* Tidy up code

* Use simple map

* go mod tidy

* Move back to data structure

- Uses less memory by creating for each language a map.

* Apply suggestions from code review

Co-authored-by: delvh <[email protected]>

* Add some comments

* Fix tests

* Try to fix tests

* Use en-US as defacto fallback

* Use correct slices

* refactor (#4)

* Remove TryTr, add log for missing translation key

* Refactor i18n

- Separate dev and production locale stores.
- Allow for live-reloading in dev mode.

Co-authored-by: zeripath <[email protected]>

* Fix live-reloading & check for errors

* Make linter happy

* live-reload with periodic check (#5)

* Fix tests

Co-authored-by: delvh <[email protected]>
Co-authored-by: 6543 <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: zeripath <[email protected]>
@kousu kousu changed the title Hide 'git-annex' and 'synced/' branches annex: Hide 'git-annex' and 'synced/' branches Nov 30, 2022
@kousu
Copy link
Member Author

kousu commented Mar 2, 2023

Relatedly, these branches should not trigger webhooks. They should be invisible, except to git pull and git push.

The route to view them (/{user}/{repo}/src/branch/{branch}/...) should give 404 (or 403?).

Is there any other feature they need to be hidden from?

@kousu kousu changed the title annex: Hide 'git-annex' and 'synced/' branches annex: Hide git-annex and synced/* branches Mar 2, 2023
@kousu
Copy link
Member Author

kousu commented Mar 3, 2023

Also here in the messages returned over ssh:

push origin 
Énumération des objets: 294, fait.
Décompte des objets: 100% (294/294), fait.
Compression par delta en utilisant jusqu'à 128 fils d'exécution
Compression des objets: 100% (133/133), fait.
Écriture des objets: 100% (152/152), 12.68 Kio | 1.58 Mio/s, fait.
Total 152 (delta 103), réutilisés 0 (delta 0), réutilisés du pack 0
remote: Résolution des deltas: 100% (103/103), complété avec 97 objets locaux.
remote: 
remote: Create a new pull request for 'synced/git-annex':
remote:   http://localhost:3000/kousu/spine-generic-processed/compare/master...synced/git-annex
remote: 
remote: . Processing 1 references
remote: Processed 1 references in total
To localhost:kousu/spine-generic-processed.git
   ecc971f37..316a4ea11  git-annex -> synced/git-annex

@mguaypaq
Copy link
Member

mguaypaq commented Mar 9, 2023

That would mean that these branches can only be manipulated from the command-line, which is fine I guess. Also, it will be impossible to suggest a fix to someone else's git-annex branch without having write access to the repository. But we can live with that, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants