Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] PPG peak detection: Add MSPTDfast algorithm (Charlton et al., 2024) #1018

Merged

Conversation

peterhcharlton
Copy link
Contributor

Added MSPTDfast algorithm (v.1.1) for PPG beat detection.

Description

This PR aims at adding the MSPTDfast algorithm (v.1.1) for PPG beat detection. This algorithm is a python implementation of the Matlab algorithm available at: https://github.com/peterhcharlton/ppg-beats/blob/main/source/msptdfastv1_beat_detector.m .

Proposed Changes

I changed the ppg_findpeaks() function by adding this additional beat detection method.

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

Added MSPTDfast algorithm (v.1.1) for PPG beat detection.
@DominiqueMakowski
Copy link
Member

Thanks a lot @peterhcharlton ! and sorry for the late reply

@DominiqueMakowski DominiqueMakowski changed the title Add MSPTDfast algorithm [Feature] PPG peak detection: Add MSPTDfast algorithm (Charlton et al., 2024) Aug 5, 2024
@DominiqueMakowski DominiqueMakowski merged commit ee87db7 into neuropsychology:dev Aug 5, 2024
8 checks passed
@danibene
Copy link
Collaborator

danibene commented Aug 5, 2024

Hi @DominiqueMakowski I saw you assigned me this then merged, any action needed on my part?

@DominiqueMakowski
Copy link
Member

Yeah I checked and thought it was unnecessary to tag you on this one as well (but it was too late :p )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants