html-template: Update to [email protected]

[edmorley]

The new version includes jantimon/html-webpack-plugin#1048, which means we can remove the temporary additions made in #1121.

[eliperelman]

@edmorley could you tell me how this is a breaking change?

[edmorley]

It's only breaking in a pedantic sense - the upstream implementation (that I wrote) uses mode to determine whether "in production", whereas my temporary workaround used NODE_ENV. Most of the time the two approaches will have the same result since Neutrino forces the two to match, apart from in the else case here:

neutrino/packages/neutrino/index.js

Lines 20 to 25 in 6948fc3

	} else {
	// Default NODE_ENV to the more strict value, to save needing to do so in .eslintrc.js.
	// However don't set `mode` since webpack already defaults it to `production`, and in so
	// doing outputs a useful message informing users that they are relying on the defaults.
	process.env.NODE_ENV = 'production';
	}

[edmorley]

Oh actually, webpack defaults mode to production itself, so this can never be breaking, even in that else case.

[edmorley]

Merging this now since otherwise Renovate will shortly be opening up a duplicate PR (but without the cleanup changes) due to reaching end of the unpublish-safe 24 hour window. Happy to make any changes from further review comments in a follow-up if needed.