Improve --enable-glamor behaviour #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes the following improvements to the xorgxrdp build process when --enable-glamor is used:- 1) Adds $LIBDRM_CFLAGS to the include path (where required) to ensure drm_fourcc.h can be located 2) Adds an explicit link dependency on the Xorg module libglamoregl.so to libxorgxrdp.so. 3) Adds the Xorg module path to the RPATH for libxorgxrdp.so, so the run-time linker can find libglamoregl.so 3) 'make check' is now added to the CI for --enable-glamor builds. On Linux this checks that all module symbols can be resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #294
This PR makes the following improvements to the xorgxrdp build process when
--enable-glamoris used:-$LIBDRM_CFLAGSto the include path (where required) to ensure drm_fourcc.h can be locatedEssentially this patch upstreams this patch file from Arch AUR which was created (I believe) by @jat001
@jat001, @Chocobo1 - please feel free to comment