Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning to xrdp_client_info #1813

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

matt335672
Copy link
Member

As discussed in gitter, add a version guard to xrdp_client_info.

There's probably more that can be done here in terms of restructuring this. I notice a lot of the stuff above the line 'Private to xrdp below this line' is not actually used by xorgxrdp. Alternatively, maybe we should split this into two structures so the compiler can pick up differences. Thoughts?

BTW : the include's been run through astyle. All I've actually done is add the 'version' field and the macro and change the comment 'NO CHANGES ABOVE THIS LINE' to the (hopefully) more informative 'Private to xrdp below this line'

@aquesnel
Copy link
Contributor

aquesnel commented Mar 1, 2021

Since the client info struct is being dumped onto the wire between xrdp and xorgxrdp, it seems sensible to minimize there data that is being sent to just the required fields, as long as backwards comparability can be maintained.

@matt335672
Copy link
Member Author

Agreed.

At the moment it's a challenge to change the client_info, as there's more in it that the xorgxrdp driver actually needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants