Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waitforx logging improvements #2586

Merged
merged 2 commits into from
Mar 18, 2023

Conversation

matt335672
Copy link
Member

As mentioned on Gitter, this makes a few changes to the waitforx executable:-

  1. Executable is now in $libexecdir/xrdp/waitforx as it isn't user facing and doesn't need to be on the PATH.
  2. The logging and error status mechanisms are significantly improved to allow for better logging of the problem(s) encountered with the X server.

You might find you also need neutrinolabs/xorgxrdp#254 in some situations.

@@ -5,7 +5,7 @@ AM_CPPFLAGS = \
-DXRDP_SYSCONF_PATH=\"${sysconfdir}\" \
-DXRDP_CFG_PATH=\"${sysconfdir}/xrdp\" \
-DXRDP_SBIN_PATH=\"${sbindir}\" \
-DXRDP_BIN_PATH=\"${bindir}\" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@matt335672 matt335672 force-pushed the move_xrdp_waitforx branch 3 times, most recently from 466b757 to 408eeb1 Compare March 13, 2023 21:16
@matt335672
Copy link
Member Author

I'm going to merge this. Further comments on waitforx can be added to #2592

@matt335672 matt335672 merged commit 42be576 into neutrinolabs:devel Mar 18, 2023
@matt335672 matt335672 deleted the move_xrdp_waitforx branch October 5, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants