Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple environments: parameterize Lambda name and NR_TAGS #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jnoss
Copy link

@jnoss jnoss commented Jul 30, 2021

This PR adds support for deploying multiple New Relic log ingestion lambdas in the same AWS account/region (by adding a Lambda function name suffix parameter in SAM). Before this change it was not possible to have multiple environments of the Lambda because the name of the Lambda was a static string in the SAM template; Lambda names must be unique in every AWS account/region so the Serverless Application Repository-managed lambda could only be deployed once. This PR also adds a SAM parameter for NR_TAGS to be able to configure New Relic Logs tags during the deploy of each of those Lambdas.

The use case for this has multiple aspects:

  • to have separate New Relic log ingestion lambdas for different environments in the same AWS account/region in order to isolate the logging infrastructure for those environments from potential deployment/concurrency issues and allow testing of new features in a test environment
  • to be able to vary the New Relic Logs tags on each of those separate lambdas, for example to identify the environment of an application sending logs to New Relic

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mrickard
Copy link
Member

Thank you for your contribution, @jnoss ! Would you be willing to rebase against the current master branch, and sign your first commit? (Alternatively, you could squash both into one, but we'd need that to be signed as well.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants