Set service_name from Log Group and hostname from Log Stream #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets the New Relic Logs attribute `service_name` to the CloudWatch Log Group (trailing portion `/` delimited), and sets the attribute `hostname` to the trailing portion of the CloudWatch Log Stream (`/` or `]` delimited, the ECS task ID for ECS logs or identifier for an instance of a Lambda). Without this change, both of those fields are N/A in New Relic Logs if the application is not setting them in the log message.
|
Thank you again, @jnoss ! And apologies for the delay in getting to this PR. At this point, I'd be happy to accept this once you've rebased against the current master branch. |
|
|
|
Hi @jnoss! Would you be able to sign the CLA for this? If you could do so, then we should be able to merge this after the branch has been rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the name of the CloudWatch Log Group and Log Stream to set the Service Name and hostname attributes in New Relic Logs. This is useful for applications that do not set those in their own logs.
Details:
service_namewill be set to the CloudWatch Log Group (trailing portion/delimited), andhostnamewill be set to the trailing portion of the CloudWatch Log Stream (/or]delimited, the ECS task ID for ECS logs or identifier for an instance of a Lambda).Without this change, both of those fields are N/A in New Relic Logs if the application is not setting them in the log message.