Cassandra-Datastax 3 instrumentation #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovesh-ap
reviewed
Oct 9, 2023
|
|
||
| @Weave(type = MatchType.ExactClass, originalName = "com.datastax.driver.core.SessionManager") | ||
| abstract class SessionManager_Instrumentation { | ||
| final Cluster cluster = Weaver.callOriginal(); |
There was a problem hiding this comment.
Please use getter instead of class member
| private final Object[] values = Weaver.callOriginal(); | ||
| private final Map<String, Object> namedValues = Weaver.callOriginal(); | ||
| @WeaveAllConstructors | ||
| public SimpleStatement_Instrumentation() { |
There was a problem hiding this comment.
Please weave all constructors separately and do not use weaving of member variables
lovesh-ap
reviewed
Oct 9, 2023
| SQLOperation cqlOperation = new SQLOperation(this.getClass().getName(), CassandraUtils.METHOD_EXECUTE_ASYNC); | ||
| cqlOperation.setQuery(query); | ||
| cqlOperation.setCaseType(VulnerabilityCaseType.NOSQL_DB_COMMAND); | ||
| cqlOperation.setDbName(CassandraUtils.EVENT_CATEGORY); |
There was a problem hiding this comment.
Discuss with SE team what are they expecting in DB name
lovesh-ap
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instrumentation Cassandra Datastax 3