Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable distributed tracing #80

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: enable distributed tracing #80

wants to merge 1 commit into from

Conversation

amc40
Copy link

@amc40 amc40 commented Jan 5, 2024

Closes #56

Implemented @rudouglas' suggestions from this comment

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

tabathadelane
tabathadelane previously approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@tabathadelane tabathadelane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to get distributed tracing data logged from one of our sites running locally that uses this plugin after applying this change. 👍

@tabathadelane tabathadelane dismissed their stale review February 12, 2024 23:15

this change as is enables this feature for every application using this plugin. is this the behavior we want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabathadelane tabathadelane tabathadelane left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support distributed tracing
4 participants
@amc40 @CLAassistant @tabathadelane @alacho22