Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove all extraneous version constraints #940

Conversation

rittneje
Copy link
Contributor

@rittneje rittneje commented Aug 1, 2024

Fixes #939.

As per the README, Go 1.18+ is already required. Thus version constraints for 1.9 and 1.10 are unnecessary. (And these currently cause issues with 1.23rc2 due to golang/go#68658.)

@CLAassistant
Copy link

CLAassistant commented Aug 1, 2024

CLA assistant check
All committers have signed the CLA.

@nr-swilloughby nr-swilloughby changed the base branch from master to develop August 1, 2024 07:24
@iamemilio
Copy link
Contributor

iamemilio commented Aug 2, 2024

Hey @rittneje, can you rebase on develop. This commit is pulling in a lot of excess.

@iamemilio
Copy link
Contributor

#941

@rittneje rittneje force-pushed the bugfix/remove-extraneous-version-constraints branch from e98a812 to 3dcea2b Compare August 2, 2024 15:47
@rittneje
Copy link
Contributor Author

rittneje commented Aug 2, 2024

@iamemilio done

@iamemilio
Copy link
Contributor

It looks like there is a stray commit still attached. Is it ok if we use this pull request containing your commit: #941? You are still credited on the commit, it just also lets me run it along side changes I just made to the test suite so that we can verify that go1.23rc runs as expected

@iamemilio
Copy link
Contributor

Oh, I am just noticing now that the protobuff changes went into master instead of develop, and that is whats causing this

@iamemilio
Copy link
Contributor

I can merge this here then, and I will rebase my commit on top.

@iamemilio iamemilio merged commit 21bf8ad into newrelic:develop Aug 2, 2024
53 checks passed
@iamemilio
Copy link
Contributor

Thanks @rittneje

@gunturaf
Copy link
Contributor

gunturaf commented Aug 15, 2024

Hi @iamemilio sorry for tagging you,
I think the commit 0fb9108 broke the deps.

This is an excerpt of what I got:

../file.go:6:2: github.com/newrelic/go-agent/[email protected] requires
	google.golang.org/[email protected]: reading google.golang.org/protobuf/go.mod at revision v1.5.3: unknown revision v1.5.3

This page https://pkg.go.dev/google.golang.org/protobuf?tab=versions shows that v1.5.3 is nonexistent.
We may replace it with v1.34.1 (it seems we can't replace with the latest tag because it requires us to bump minimum go version to 1.20)

@gunturaf
Copy link
Contributor

I've made a PR that might resolve that, please help review it #948 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with Go 1.23 due to extraneous version constraint
5 participants