Tracing Re-Work and Context Support #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is getting really, big so I am making sure that the unit tests to cover these changes are in absolute tip top shape |
A new library for tracking stateful information related to tracing has been created. This allows us to easily consolidate code and decision making related to how tracing information is handled.
- Capture errors that are returned from functions - Improve support for tracing function literals - Fix Goroutine tracing behavior in main methods - Allow transactions to be passed to contexts - Better testing coverage for tracing
The new subobject of tracestate, traceobject now has a complete suite of unit tests. This will ensure long term development is stable and reliable. End to End tests were also updated and enhanced to cover the new additions.
iamemilio
force-pushed
the
tracing_types_latest
branch
from
ac80388
to
ceeb2a2
Compare
|
This is ready for review, and has been squashed down into more digestible commits. |
iamemilio
changed the title
mirackara
reviewed
Nov 14, 2024
parser/agent.go
Outdated
| } | ||
|
|
||
| // Always load the error into the cache | ||
| fmt.Println("loaded into cache: ", errExpr) |
There was a problem hiding this comment.
Leftover print statement
mirackara
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very serious re-structuring of the way that tracing information is passed and stored, allowing us to move logic related to it into a centralized code location. This lets us define our situational policy for how tracing gets handled and passed in one place, and then invoke that library like an SDK to access tracing throughout the application. This should enable much more easy tracing for libraries that we integrate moving forward, and will substantially reduce the bug burden in the long run.
Core changes