Null Throwable are generating repetitive logs in Console. #309
Conversation
| if (null != throwable) { | ||
| StringWriter sw = new StringWriter(); | ||
| throwable.printStackTrace(new PrintWriter(sw)); | ||
| message = String.format(Locale.getDefault(), "%s: %s", message, sw); |
There was a problem hiding this comment.
Don't replace message with a non-null throwable. Both may be valid. Your condition should only be if throwable is null.
There was a problem hiding this comment.
changes done.
ndesai-newrelic
force-pushed
the
NR-336701_Null_Throwable_ND
branch
from
4466e26
to
d09ed6a
Compare
| } else { | ||
| StringWriter sw = new StringWriter(); | ||
| throwable.printStackTrace(new PrintWriter(sw)); | ||
| message = String.format(Locale.getDefault(), |
There was a problem hiding this comment.
Same here, message may be valid.
There was a problem hiding this comment.
i am creating the message, we are creating it from attributes.
| throwable.printStackTrace(new PrintWriter(sw)); | ||
| if (null == throwable) { | ||
| logToAgent(logLevel, message); | ||
| return; |
There was a problem hiding this comment.
Should not abort the entire call is throwable is null.
There was a problem hiding this comment.
I am just passing the message if the throwable is null. We don't need to validate the message because it is already getting validated in the logToAgent method.
…elic/newrelic-android-agent into NR-336701_Null_Throwable_ND
ndesai-newrelic
force-pushed
the
NR-336701_Null_Throwable_ND
branch
from
d09ed6a
to
1797d1c
Compare
android log is also not printing null for null throwable. |
#280