Http Status code - indentation fixes, adding final to some fields

newrelic · Nov 16, 2021 · 876591d · 876591d
1 parent 18ba60f
commit 876591d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 12 deletions.
diff --git a/...ntation-test/src/main/java/com/newrelic/agent/introspec/internal/ExternalRequestImpl.java b/...ntation-test/src/main/java/com/newrelic/agent/introspec/internal/ExternalRequestImpl.java
@@ -23,12 +23,12 @@ class ExternalRequestImpl extends RequestImpl implements ExternalRequest {
     private static Pattern EXTERNAL_TX_METRIC = Pattern.compile("ExternalTransaction/([^/]+)/(.+)");
     private static Pattern EXTERNAL_TX_SEGMENT = Pattern.compile("ExternalTransaction/([^/]+)/(.+)");
 
-    private String library;
-    private String operation;
-    private Integer statusCode;
-    private String statusText;
-    private String segmentName;
-    private String catTransactionGuid;
+    private final String library;
+    private final String operation;
+    private final Integer statusCode;
+    private final String statusText;
+    private final String segmentName;
+    private final String catTransactionGuid;
 
     private ExternalRequestImpl(String originalMetric, String segmentName, String host, String lib, String operation, Integer statusCode, String statusText,
             String catTransactionGuid) {

diff --git a/...src/main/java/org/apache/http/nio/protocol/HttpAsyncResponseConsumer_Instrumentation.java b/...src/main/java/org/apache/http/nio/protocol/HttpAsyncResponseConsumer_Instrumentation.java
@@ -90,8 +90,7 @@ public void failed(Exception ex) {
     }
 
     private Integer getStatusCode() {
-        if (httpResponse != null && httpResponse.getStatusLine() != null)
-        {
+        if (httpResponse != null && httpResponse.getStatusLine() != null) {
             return httpResponse.getStatusLine().getStatusCode();
         }
         return null;

diff --git a/...client-1.0/src/main/java/com/nr/agent/instrumentation/asynchttpclient/NRAsyncHandler.java b/...client-1.0/src/main/java/com/nr/agent/instrumentation/asynchttpclient/NRAsyncHandler.java
@@ -125,8 +125,7 @@ public T onCompleted() throws Exception {
     }
 
     private Integer getStatusCode() {
-        if (responseStatus != null)
-        {
+        if (responseStatus != null) {
             return responseStatus.getStatusCode();
         }
         return null;

diff --git a/newrelic-api/src/main/java/com/newrelic/api/agent/HttpParameters.java b/newrelic-api/src/main/java/com/newrelic/api/agent/HttpParameters.java
@@ -113,7 +113,7 @@ public String getProcedure() {
      * Returns the HTTP status code for the call.
      *
      * @return the status code for the call, null if not available
-     * @since 6.5.0
+     * @since 7.5.0
      */
     public Integer getStatusCode() {
         return statusCode;
@@ -123,7 +123,7 @@ public Integer getStatusCode() {
      * Returns the HTTP reason message for the call.
      *
      * @return the text of the reason message, null if not available
-     * @since 6.5.0
+     * @since 7.5.0
      */
     public String getStatusText() {
         return statusText;