Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instrumentation Support for Spring JMS 6.0.0 #1088

Closed
tbradellis opened this issue Nov 22, 2022 · 4 comments
Closed

Instrumentation Support for Spring JMS 6.0.0 #1088

tbradellis opened this issue Nov 22, 2022 · 4 comments

Comments

@tbradellis
Copy link
Contributor

Spring 6.0.0 released 11/16
We will need a new instrumentation module to support these changes.

// https://mvnrepository.com/artifact/org.springframework/spring-jms
implementation 'org.springframework:spring-jms:6.0.0'

229 actionable tasks: 218 executed, 11 up-to-date
     Verifier output:
     Creating user classloader with custom classpath:
     	/home/runner/.gradle/caches/modules-2/files-2.1/org.springframework/spring-jms/6.0.0/1e13f32802a53fcbe2380c8abf502a01ca5840bf/spring-jms-6.0.0.jar
     	/home/runner/.gradle/caches/modules-2/files-2.1/org.springframework/spring-messaging/6.0.0/c3e46c8f6fd7939dbe7b78ef9ff29fa733efcb52/spring-messaging-6.0.0.jar
     	/home/runner/.gradle/caches/modules-2/files-2.1/org.springframework/spring-tx/6.0.0/759573b65e86c7111206388a1fb13997fdeec8af/spring-tx-6.0.0.jar
     	/home/runner/.gradle/caches/modules-2/files-2.1/org.springframework/spring-beans/6.0.0/88cb443c4ef133f0114edc94f1ab93f5a647a481/spring-beans-6.0.0.jar
     	/home/runner/.gradle/caches/modules-2/files-2.1/org.springframework/spring-core/6.0.0/b374a930c61b606e2e73503cc107501e1e967a2b/spring-core-6.0.0.jar
     	/home/runner/.gradle/caches/modules-2/files-2.1/org.springframework/spring-jcl/6.0.0/7433b466690805ebea45df97dba7c5a1f81c9e7e/spring-jcl-6.0.0.jar
     WeaveViolation{type=METHOD_NEW_CALL_ORIGINAL_UNSUPPORTED, clazz=org/springframework/jms/listener/SessionAwareMessageListener, method=onMessage(Ljavax/jms/Message;Ljavax/jms/Session;)V}
     WeaveViolation{type=METHOD_NEW_NON_PRIVATE_UNSUPPORTED, clazz=org/springframework/jms/listener/SessionAwareMessageListener, method=onMessage(Ljavax/jms/Message;Ljavax/jms/Session;)V}

Priority

Please help us better understand this feature request by choosing a priority from the following options:
Must have

@workato-integration
Copy link

@workato-integration workato-integration bot changed the title Instrumentation Support for Spring JMS 6.0.0 Instrumentation Support for Spring JMS 6.0.0 Nov 22, 2022
@workato-integration
Copy link

Jira CommentId: 168215
Commented by bellis:

#1179

@workato-integration
Copy link

Jira CommentId: 168216
Commented by bellis:

Updated docs to remove the explicit reference to Spring Boot 3
[https://github.com/newrelic/docs-website/pull/12083]

{code:java}
Spring Boot is not a library in and of itself. It is a collection of Spring modules/libraries. Our instrumentation targets certain libraries/modules and we provide instrumentation for a range of versions for some individual libraries. It is misleading to say we support Spring Boot X, because we do not provide instrumentation for every library in Spring Boot. Instead, we should list the libraries for which we provide instrumentation, along with the range of versions. Removing this Spring Boot line achieves that. {code}

@workato-integration
Copy link

Work has been completed on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant