Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Spring Boot support designation #12083

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Remove Spring Boot support designation #12083

merged 1 commit into from
Mar 15, 2023

Conversation

tbradellis
Copy link
Contributor

Spring Boot is not a library in and of itself. It is a collection of Spring modules. Our instrumentation targets certain libraries/modules and we provide instrumentation for a range of versions for some individual libraries. It is misleading to say we support Spring Boot X, because we do not provide instrumentation for every library in Spring Boot. Instead, we should list the libraries for which we provide instrumentation, along with the range of versions. Removing this Spring Boot line achieves that.

Please follow conventional commit standards
in your commit messages and pull request title.

Give us some context

  • What problems does this PR solve?
  • Add any context that will help us review your changes such as testing notes,
    links to related docs, screenshots, etc.
  • If your issue relates to an existing GitHub issue, please link to it.

Spring Boot is not a library in and of itself.  It is a collection of Spring modules.  Our instrumentation targets certain libraries/modules and we provide instrumentation for a range of versions for some individual libraries.  It is misleading to say we support Spring Boot X, because we do not provide instrumentation for every library in Spring Boot.  
Instead, we should list the libraries for which we provide instrumentation, along with the range of versions.  Removing this Spring Boot line achieves that.
@github-actions
Copy link

Hi @tbradellis 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

@nbaenam nbaenam self-requested a review March 15, 2023 11:49
@nbaenam nbaenam self-assigned this Mar 15, 2023
@nbaenam nbaenam added content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers) labels Mar 15, 2023
Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update!

@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 15, 2023

✅ docs-website-develop deploy preview ready

@nbaenam nbaenam merged commit 5733fec into newrelic:develop Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_internal Identifies issues/PRs from Relics (except writers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants