Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spring Data R2DBC instrumentation #197

Closed
5 tasks done
tspring opened this issue Jan 26, 2021 · 3 comments
Closed
5 tasks done

Spring Data R2DBC instrumentation #197

tspring opened this issue Jan 26, 2021 · 3 comments
Assignees
@GDownes
Labels
enhancement New feature or request
Milestone
Improve Data Sour...

Comments

@tspring
Copy link
Contributor

tspring commented Jan 26, 2021 •
edited by twcrone
Loading

Instrumentation and instrumentation tests for R2DBC.

Add R2DBC support for the following drivers:

  • MySQL
  • MariaDB
  • Oracle
  • MSSQL
  • Postgres
@XiXiaPdx XiXiaPdx added this to the Spring Reactive DB Drivers milestone Jan 26, 2021
@XiXiaPdx XiXiaPdx added the enhancement New feature or request label Jan 26, 2021
@mp911de
Copy link

mp911de commented Feb 5, 2021

FWIW, R2DBC provides an Invocation proxy (https://github.com/r2dbc/r2dbc-proxy) to intercept calls for obserability/tracing/metrics implementations.

@XiXiaPdx XiXiaPdx self-assigned this Mar 18, 2021
@kford-newrelic kford-newrelic mentioned this issue Jan 14, 2022
Closed
@kford-newrelic
Copy link
Contributor

Might target the H2 database for the initial implementation.

@GDownes GDownes mentioned this issue Feb 25, 2022
Merged
@GDownes GDownes mentioned this issue Feb 28, 2022
Closed
@kford-newrelic kford-newrelic mentioned this issue Mar 1, 2022
Closed
@kford-newrelic
Copy link
Contributor

Remaining driver work bumped from the 7.6.0 release. Will target a subsequent agent release instead.

@GDownes GDownes mentioned this issue Mar 22, 2022
Merged
@GDownes GDownes mentioned this issue Apr 4, 2022
Merged
@GDownes GDownes mentioned this issue Apr 11, 2022
Merged
GDownes added a commit that referenced this issue Apr 26, 2022
@GDownes
R2DBC MSSQL Instrumentation - Instrumentation to capture execute call…
7b2c2db 
…s when using MSSQL via R2DBC.

Instruments the SimpleMssqlStatement and ParametrizedMssqlStatement child classes of the R2DBC Statement interface implementation. Higher level R2DBC Statement interface doesn't provide enough information to instrument more generically.

Related Github Issue
#197

Testing
Manual testing

Checks
[X] Are your contributions backwards compatible with relevant frameworks and APIs? New instrumentation
[X] Does your code contain any breaking changes? Please describe. No
[X] Does your code introduce any new dependencies? Please describe. Yes, new instrumentation dependencies in new project.
This was referenced Apr 26, 2022
Merged
Merged
twcrone pushed a commit that referenced this issue Apr 26, 2022
@GDownes
MSSQL R2DBC Instrumentation (#828)
c79d7fe 
* R2DBC MSSQL Instrumentation - Instrumentation to capture execute calls when using MSSQL via R2DBC.
Instruments the SimpleMssqlStatement and ParametrizedMssqlStatement child classes of the R2DBC Statement interface implementation. Higher level R2DBC Statement interface doesn't provide enough information to instrument more generically.

Related Github Issue
#197

Testing
Manual testing

Checks
[X] Are your contributions backwards compatible with relevant frameworks and APIs? New instrumentation
[X] Does your code contain any breaking changes? Please describe. No
[X] Does your code introduce any new dependencies? Please describe. Yes, new instrumentation dependencies in new project.

* Change name and query converter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GDownes GDownes

Labels
enhancement New feature or request
Projects
Java Engineering Board
Archived in project
Milestone
Improve Data Source Metrics
Development

No branches or pull requests
7 participants
@GDownes @tspring @mp911de @richard-gibson @jasonjkeller @XiXiaPdx @kford-newrelic