Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the agent to support Java 17 #418

Closed
9 tasks done
jasonjkeller opened this issue Sep 10, 2021 · 2 comments
Closed
9 tasks done

Update the agent to support Java 17 #418

jasonjkeller opened this issue Sep 10, 2021 · 2 comments
Assignees

Comments

@jasonjkeller
Copy link
Contributor

jasonjkeller commented Sep 10, 2021

This should be pretty straightforward, see the work that was done to support Java 16 for guidance.

  • Upgrade ASM version
  • Update use of ASM Opcodes in agent (see WeaveUtils.ASM_API_LEVEL)
  • Address all classes with the following comment: NOTE: If you are upgrading from org.ow2.asm:asm / org.ow2.asm:asm-tree make sure to double check that this class hasn't changed between versions.
  • Configure tests to run with Java 17 JRE
  • Update JavaVersionUtils and related test
  • Add Java17IncompatibleTest marker interface and annotate tests that are incompatible with Java 17
  • Ensure all unit tests pass
  • Ensure all functional tests pass
  • Ensure all instrumentation tests pass
@jasonjkeller jasonjkeller added this to the Java 17 Support milestone Sep 10, 2021
@tbradellis tbradellis self-assigned this Sep 27, 2021
@twcrone twcrone self-assigned this Sep 27, 2021
@nealeu
Copy link

nealeu commented Oct 23, 2021

Wondering why our latest deploys are having issues with getting data to NewRelic. We really did not expect the situation where:

  • Java 16 support arrives 2 weeks after the release of Java 17
  • Java 17 support is still not available 5 weeks after.

The expectation of companies that we are paying for tooling is that, like Eclipse, JetBrains, Microsoft, Amazon, Google, and countless others, that companies would use preview builds to get this stuff sorted and to have support released prior to the formal release.

Shocked!

@kford-newrelic
Copy link
Contributor

Our 7.4.0 release now supports Java 17!

Appreciate you sharing your thoughts about our timeline to get to Java 17 - we intend to support newer Java versions sooner going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

5 participants