NEWRELIC-658 check expected error config for noticeError api #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbradellis
commented
Sep 21, 2022
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
tbradellis
commented
Sep 21, 2022
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
tbradellis
commented
Sep 21, 2022
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
tbradellis
force-pushed
the
expected-errors-notice-error-api
branch
2 times, most recently
from
a5a4f31
to
25ec781
Compare
tbradellis
commented
Sep 29, 2022
newrelic-agent/src/test/java/com/newrelic/api/agent/NewRelicApiImplementationTest.java
Outdated
Show resolved
Hide resolved
tbradellis
commented
Sep 29, 2022
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
tbradellis
commented
Sep 29, 2022
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
tbradellis
commented
Sep 29, 2022
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
tbradellis
force-pushed
the
expected-errors-notice-error-api
branch
from
315a0d2
to
9741701
Compare
tbradellis
commented
Sep 29, 2022
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
tbradellis
force-pushed
the
expected-errors-notice-error-api
branch
from
be2f913
to
69f4488
Compare
jasonjkeller
reviewed
Oct 3, 2022
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
newrelic-agent/src/main/java/com/newrelic/api/agent/NewRelicApiImplementation.java
Outdated
Show resolved
Hide resolved
tbradellis
force-pushed
the
expected-errors-notice-error-api
branch
from
ff54fcc
to
338e527
Compare
use placeholder for config format rm double check still check for null corrections for config check tweak to fix Supportability metrics account for null throwable rm stand-in test handle null throwable refactor no expected strings remove hack reformat file. drop unused var tests for config+expected+noticeErrorAPI checkout APITest from main must close environment holder call for the correct count optimize imports remove bad test remove invalid test review revisions. clean code fix supportability check refactor no expectedByAPI bool
tbradellis
force-pushed
the
expected-errors-notice-error-api
branch
from
e4ec0ec
to
3e46800
Compare
jasonjkeller
approved these changes
Oct 4, 2022
tbradellis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The changes here force the noticeError API to check the expected error configuration when using APIs that do not explicitly set the expected boolean.
Previously, we just passed false all the way through and the expected boolean only gets set if the caller uses the API that includes the boolean.
Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
Tested with local apps and config.
This will add new tests.
Checks
[ yes] Are your contributions backwards compatible with relevant frameworks and APIs?
[ no] Does your code contain any breaking changes? Please describe.
[ no] Does your code introduce any new dependencies? Please describe.