NEWRELIC-4831 Clean up deprecated attributes #1125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiao
approved these changes
Jan 20, 2023
| * when the ServerStream is closed or cancelled. | ||
| * | ||
| * @param status The {@link Status} of the completed/cancelled operation | ||
| */ | ||
| public static void setServerStreamResponseStatus(Status status) { | ||
| if (status != null) { | ||
| NewRelic.addCustomParameter("response.status", status.getCode().value()); | ||
| NewRelic.addCustomParameter("http.statusCode", status.getCode().value()); |
There was a problem hiding this comment.
Nice catch. This instrumentation module was around the same time the attribute name change happened, but the author did not notice that.
meiao
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove deprecated attributes:
httpResponseCode,httpResponseMessageChecks
[Y] Are your contributions backwards compatible with relevant frameworks and APIs?
[N] Does your code contain any breaking changes? Please describe.
[N] Does your code introduce any new dependencies? Please describe.