Newrelic-57520 kafka streams #1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es (will add back later)
…ucer and the consumer.
meiao
reviewed
Mar 6, 2023
...etrics-1.0.0/src/main/java/com/nr/instrumentation/kafka/streams/NewRelicMetricsReporter.java
Outdated
Show resolved
Hide resolved
instrumentation/kafka-streams-spans-2.0.0/src/test/java/KafkaStreams2SpansTest.java
Outdated
Show resolved
Hide resolved
...streams-spans-3.2.0/src/main/java/com/nr/instrumentation/kafka/streams/StreamsSpansUtil.java
Outdated
Show resolved
Hide resolved
meiao
approved these changes
Mar 8, 2023
jtduffy
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds new instrumentation modules for Kafka Streams, one to export Kafka Streams metrics and others to create transactions and spans. Our spans modules support Streams Versions 2.0.0 and up and our metrics instrumentation works for Streams Version 1.0.0 and up.