NR-64061 Add user tracking to transactions and errors via the "enduser.id" attribute #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obenkenobi
requested review from
jasonjkeller,
jtduffy,
tbradellis,
meiao and
jbedell-newrelic
obenkenobi
changed the title
jtduffy
approved these changes
Mar 24, 2023
meiao
reviewed
Mar 27, 2023
instrumentation/servlet-user-5.0/src/main/java/jakarta/servlet/Servlet.java
Outdated
Show resolved
Hide resolved
meiao
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds user tracking to transactions and errors in a way that will be consistent to other APM agents.
A new method in our public API is added called
NewRelic.setUserId(String userId)that sets anenduser.idattribute to a transaction. It in turns passes that attribute into errors linked to that transaction.In addition, the servler-user and servlet-user-5.0 instrumentation was modified to also set the enduser.id attribute using the name of a provided principle in a Servlet / Filter.