Spring-webflux 5.3 instrumentation #121
Conversation
|
Hi @hisener , While this PR hasn't been reviewed yet, I would expect it to be in the next week or two and included in the next agent release (6.3.0). If you'd be willing to test these changes and offer any feedback, that'd be welcome as well! Cheers. |
| if (token != null) { | ||
| token.linkAndExpire(); | ||
| } | ||
| runnable.run(); |
There was a problem hiding this comment.
I noticed that this line is missing in the same file in spring-webflux-5.1.0 and spring-webflux-5.0.0 modules. Is that a bug there or here?
There was a problem hiding this comment.
It was the issue fixed in #114
There was a problem hiding this comment.
Ah I see so this branch just hasn't been rebased to in include that code.
|
|
||
| @RunWith(InstrumentationTestRunner.class) | ||
| @InstrumentationTestConfig(includePrefixes = { "org.springframework" }) | ||
| public class Spring510RouterFunTest { |
There was a problem hiding this comment.
Rename to Spring530RouterFunTest, no?
|
@jack-berg the field here was changed to no longer be final. That's the only difference between the 5.1 instrumentation and 5.3 WeaveViolation{type=FIELD_FINAL_MISMATCH, clazz=org/springframework/web/reactive/function/server/RequestPredicates$PathPatternPredicate, field=pattern} |
Fixes #104