implement getStatus for nrwrapper #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1315 +/- ##
============================================
+ Coverage 60.72% 60.73% +0.01%
- Complexity 8572 8573 +1
============================================
Files 856 856
Lines 40455 40455
Branches 6076 6076
============================================
+ Hits 24565 24570 +5
+ Misses 13410 13406 -4
+ Partials 2480 2479 -1 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tbradellis
force-pushed
the
implement-getstatus-for-servlet-5-and-6-nrresponsewrapper
branch
from
4cb6a09
to
61634cd
Compare
add some code coverage for webrequestdispatcher drop unrelated tests and do separate optimize imports
tbradellis
force-pushed
the
implement-getstatus-for-servlet-5-and-6-nrresponsewrapper
branch
from
61634cd
to
1f9ac90
Compare
jtduffy
approved these changes
Jun 14, 2023
meiao
approved these changes
Jun 14, 2023
| @Override | ||
| public int getStatus() throws Exception { | ||
| return 0; | ||
| return response.getStatus(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NRResponseWrapper class in our Servlet 5 and Servlet 6 instrumentation doesn't implement the getStatus method.
This came up in testing Jakarata 10 EE. Testing shows that the http.StatusCode method was not being added to agent attributes (an assertion on attribute map length revealed the issue).
The method in the wrapper always returns 0 causing the put to the attributes to be skipped.
newrelic-java-agent/newrelic-agent/src/main/java/com/newrelic/agent/dispatchers/WebRequestDispatcher.java
Line 107 in aeb1c4e