-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instrumentation for r2dbc-postgresql-0.9.2 #1410
Conversation
I tried running the tests locally, but couldn't get that to work, and was hoping to get the workflow running here on CI, but I see that maintainer requires approval. |
Okay, got the tests to run by not running gradle with the |
1e206bd
to
19ee30a
Compare
19ee30a
to
8dc2ab3
Compare
I've encountered some problems with segments not ending properly. UPDATE: The issue already exists in the instrumentation for previous versions of the instrumentation and seems only to affect Connection creationg. |
We've been experiencing the same, also the reason newrelic is currently unusable for, and thus has been disabled for the past month already. |
The segments that were not ended were related with the creation of Connections. @koenpunt did you encounter something different? |
We didn't investigate too much in what the problem was, also because we didn't really know where to look. What didn't help was the noise the token linker produces in the traces/profiling. |
Also; we've been using it with v1.0.0 of the r2dbc library, not sure if there it's because of the same reasons? |
The issue that I found is the same across all versions. |
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Adds updated instrumentation for r2dbc-postgresql-0.9.2, since instrumentation was disabled in #999.
Related Github Issue
Include a link to the related GitHub issue, if applicable
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks