fix spring 6 pointcuts, after migration from javax to jakarta #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kford-newrelic
added
estimate
|
Closed for duplicate #1544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed that since migration to spring 6, the newrelic agent no longer sends error message when http requests fails.
SpringExceptionHandlerPointCutused to fill error message, intercepting calls toorg.springframework.web.servlet.DispatcherServlet#processHandlerException. Pointcut was defined to capture method with signature"(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Ljava/lang/Object;Ljava/lang/Exception;)Lorg/springframework/web/servlet/ModelAndView;". Spring 6 moved to jakarta, sojakartainstead ofjavaxis now used and method signature fromSpringExceptionHandlerPointCutno longer capturesorg.springframework.web.servlet.DispatcherServlet#processHandlerException.I've added new pointcuts reflecting new
jakartapackage names, used since Spring 6.0.