Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update class excludes list for Sonarqube9.9 #1522

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

kanderson250
Copy link
Contributor

fixes #1348

This PR addresses classCircularityError that appeared when running the agent with Sonarqube Server v.9.9 and Java 17.

Proposed change: add the following four classes to default excludes file:

java/util/AbstractList$RandomAccessSpliterator
java/util/stream/MatchOps$MatchOp
java/util/stream/MatchOps$BooleanTerminalSink
javax/security/auth/Subject$SecureSet$1

These are not known to be weaved by the agent or security agent but appear to fix the issue on SQ.

@kanderson250 kanderson250 requested a review from a team September 26, 2023 21:27
@codecov-commenter
Copy link

Codecov Report

Merging #1522 (cae9038) into main (2c20813) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1522      +/-   ##
============================================
- Coverage     70.60%   70.59%   -0.01%     
- Complexity     9745     9747       +2     
============================================
  Files           813      813              
  Lines         39264    39268       +4     
  Branches       5962     5963       +1     
============================================
  Hits          27723    27723              
- Misses         8856     8859       +3     
- Partials       2685     2686       +1     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kanderson250 kanderson250 merged commit 6d1cf50 into main Sep 26, 2023
103 checks passed
@kanderson250 kanderson250 deleted the sonarqube-fix branch September 26, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Spike Sonarqube 9.9 issues
3 participants