Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing HttpUrlConnection instr to not rely on segment/cleanup thread #1537

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Oct 4, 2023

Overview

This code reverts the HttpURLConnection instrumentation to something more similar with the instrumentation on 7.11.
But it fixes one problem where the externals/DT were not always in the correct span.

Related Github Issue

Fixes #1378

Checks

  • Are your contributions backwards compatible with relevant frameworks and APIs?
  • Does your code contain any breaking changes? Please describe.
  • Does your code introduce any new dependencies? Please describe.

@codecov-commenter
Copy link

Codecov Report

Merging #1537 (afe7295) into main (2c20813) will decrease coverage by 0.03%.
Report is 26 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1537      +/-   ##
============================================
- Coverage     70.60%   70.58%   -0.03%     
- Complexity     9745     9754       +9     
============================================
  Files           813      814       +1     
  Lines         39264    39300      +36     
  Branches       5962     5967       +5     
============================================
+ Hits          27723    27738      +15     
- Misses         8856     8871      +15     
- Partials       2685     2691       +6     

see 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@meiao meiao marked this pull request as draft October 4, 2023 21:51
@meiao meiao requested a review from a team October 5, 2023 20:13
@meiao meiao marked this pull request as ready for review October 5, 2023 20:14
@meiao meiao merged commit 5f6995f into main Oct 9, 2023
102 checks passed
@meiao meiao deleted the aonuki/httpurlconnection branch October 9, 2023 16:49
@contentfree
Copy link

contentfree commented Oct 23, 2023

@meiao Do you have insight into when this change will land in a release of the java agent?

@jtduffy
Copy link
Contributor

jtduffy commented Oct 23, 2023

@contentfree This will be available in the next release, targeted for Oct 26th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Investigate Java agent external metrics for potential inaccuracy
4 participants