Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize CGLIB proxied class names #1575

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Nov 6, 2023

Resolves #1574

With this change, transaction names that are composed of class name + method name from a controller that has a CGLIB proxy generated will no longer show the proxy class name but the original class name. This image shows an example of transactions names with and without this change:
Screenshot 2023-11-06 at 3 56 57 PM

@jtduffy jtduffy requested a review from a team November 6, 2023 21:01
@codecov-commenter
Copy link

Codecov Report

Merging #1575 (9b094ae) into main (f6b467b) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main    #1575      +/-   ##
============================================
- Coverage     70.61%   70.59%   -0.03%     
+ Complexity     9798     9796       -2     
============================================
  Files           817      817              
  Lines         39501    39504       +3     
  Branches       5999     6000       +1     
============================================
- Hits          27892    27886       -6     
- Misses         8901     8909       +8     
- Partials       2708     2709       +1     
Files Coverage Δ
...tcuts/frameworks/spring/MethodInvokerPointCut.java 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@jtduffy jtduffy merged commit 548d9fb into main Nov 9, 2023
102 of 103 checks passed
@jtduffy jtduffy deleted the 1574-normalize-proxy-names branch November 9, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants