Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lettuce fix #1608

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Lettuce fix #1608

merged 2 commits into from
Nov 29, 2023

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Nov 29, 2023

Overview

This PR fixes a problem that happened when multiple Lettuce commands were executed in the same transaction.

It removes transaction linking code from the Lettuce instrumentation which was duplicated from the code in the netty-reactor instrumentation.

It also introduces a reactor instrumentation for cases where Reactor is used without Netty. This instrumentation will not be loaded when the application uses Netty.

Related Github Issue

#1438

Checks

  • Your contributions are backwards compatible with relevant frameworks and APIs.
  • Your code does not contain any breaking changes. Otherwise please describe.
  • Your code does not introduce any new dependencies. Otherwise please describe.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4bc6b2e) 70.56% compared to head (58ea287) 70.64%.
Report is 28 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1608      +/-   ##
============================================
+ Coverage     70.56%   70.64%   +0.08%     
- Complexity     9794     9915     +121     
============================================
  Files           818      826       +8     
  Lines         39506    39804     +298     
  Branches       6000     6011      +11     
============================================
+ Hits          27877    28121     +244     
- Misses         8922     8970      +48     
- Partials       2707     2713       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meiao meiao marked this pull request as draft November 29, 2023 16:05
@meiao meiao marked this pull request as ready for review November 29, 2023 20:44
@meiao meiao linked an issue Nov 29, 2023 that may be closed by this pull request
@meiao meiao merged commit 57b3877 into main Nov 29, 2023
101 checks passed
@meiao meiao deleted the lettuce-fix branch November 29, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Memory leak in com.newrelic.instrumentation.lettuce-6.0
3 participants