Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Jetty 12 #1621

Merged
merged 25 commits into from
Dec 4, 2023
Merged

Add support for Jetty 12 #1621

merged 25 commits into from
Dec 4, 2023

Conversation

obenkenobi
Copy link
Contributor

@obenkenobi obenkenobi commented Dec 1, 2023

Overview

Adds instrumentation for Jetty 12.

Jetty 12 follows a philosophy of being Servlet API independent. As a result Jetty now ships with a Core Server that makes no reference to the Servlet API. In addition, Jetty now supports every Jakarta EE spec from 8 to 10. As a result, an instrumentation module is needed for each EE implementation. This PR also adds instrumentation for the core Jetty Server. As a result 5 new instrumentation modules are added. These new modules can be described as follows:

jetty-12

This module instruments the core Jetty server that handles tasks that does not require the Servlet API. Since async activity is not managed in the core server, transactions cannot be started and managed in this module. The tasks this module does include:

  • Reporting thread-pool metrics
  • Reporting the dispatcher name and version as well as the port number for the server.
  • Adding outbound CAT headers for outgoing requests. CAT however is deprecated during the time this module is made (i.e. December 2023).

jetty-ee*-servlet-12

This refers to any module named based on the pattern jetty-ee*-servlet-12.
These modules instrument the Servlet API implementations for Jetty.
As a result, the instrumentation works with tasks that require us to work with the Servlet API such as:

  • Start and ending web transactions
  • Linking transactions to async activity
  • Reporting errors

List of new instrumentation modules

  • jetty-12
  • jetty-ee8-servlet-12
  • jetty-ee9-servlet-12
  • jetty-ee10-servlet-12
  • jetty-ee10-servlet-12.0.1

Related Github Issue

#1300

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (615597c) 70.60% compared to head (737952b) 70.69%.
Report is 125 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1621      +/-   ##
============================================
+ Coverage     70.60%   70.69%   +0.08%     
- Complexity     9795     9946     +151     
============================================
  Files           817      827      +10     
  Lines         39500    39931     +431     
  Branches       5999     6031      +32     
============================================
+ Hits          27888    28228     +340     
- Misses         8904     8983      +79     
- Partials       2708     2720      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jtduffy jtduffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Aside from my inline comments:

  • Most of the class files are missing the copyright header. Those that have the header have the incorrect year (2022).

@obenkenobi
Copy link
Contributor Author

obenkenobi commented Dec 4, 2023

Looks good. Aside from my inline comments:

  • Most of the class files are missing the copyright header. Those that have the header have the incorrect year (2022).

Added the copyright headers @jtduffy

@obenkenobi obenkenobi linked an issue Dec 4, 2023 that may be closed by this pull request
@obenkenobi obenkenobi merged commit 8752d24 into main Dec 4, 2023
103 checks passed
@obenkenobi obenkenobi deleted the jetty-12 branch May 2, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants