Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding status code to grpc-1.40.0 client instrumentation #1673

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

meiao
Copy link
Contributor

@meiao meiao commented Dec 20, 2023

Overview

The grpc-1.40.0 instrumentation was missing a line that set the status code/message on grpc client spans.
This PR adds that line.

Checks

  • Your contributions are backwards compatible with relevant frameworks and APIs.
  • Your code does not contain any breaking changes. Otherwise please describe.
  • Your code does not introduce any new dependencies. Otherwise please describe.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de83f4c) 70.70% compared to head (422957e) 70.69%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1673      +/-   ##
============================================
- Coverage     70.70%   70.69%   -0.01%     
  Complexity     9960     9960              
============================================
  Files           828      828              
  Lines         39967    39967              
  Branches       6048     6048              
============================================
- Hits          28258    28256       -2     
- Misses         8980     8983       +3     
+ Partials       2729     2728       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meiao meiao merged commit ad84f2e into main Dec 21, 2023
103 checks passed
@meiao meiao deleted the grpc-status-code branch December 21, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants