1648 http response fixes #1775
Merged
1648 http response fixes #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfo from the HttpResponse that we need rather than the entire response.
Also import cleanup on spray-can-http-client-1.3.1
|
Resolves #1648 |
jtduffy
approved these changes
Feb 29, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1775 +/- ##
============================================
- Coverage 70.84% 70.83% -0.01%
- Complexity 9935 9936 +1
============================================
Files 825 825
Lines 39826 39826
Branches 6037 6037
============================================
- Hits 28214 28212 -2
- Misses 8887 8888 +1
- Partials 2725 2726 +1 ☔ View full report in Codecov by Sentry. |
|
is there a reason this change wasn't made to spring_webclient5 as well? |
|
Hi @vikinghawk , thanks for the question. At the time, in order to limit scope and potential impact, we made the decision to only update the latest version for most modules. As a result of your question, we discussed this today and decided to open a new ticket to address it for spring-webclient-5.0 as well. Here is a link to the ticket, so you can follow the progress. Thanks for getting in touch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses the latest version of each module that handles external HTTP calls. The various wrapper classes used to access the headers of the response have been changed to only hold onto the headers rather than the entire response object.