Add new akka-http-2.13_10.1.8 instrumentation module #271

jasonjkeller · 2021-04-08T18:34:56Z

Resolves #260

The akka-http-2.4.5 instrumentation wasn't applying on Scala 2.13. This PR adds a news akka-http-2.13_10.1.8 instrumentation module to support Scala 2.13. It also renames the old module and cleans up the verifier configuration which was trying to verify against versions that don't exist.

I tested with the akka http quickstart app and confirmed that the new module applies with Scala 2.13.

The customer who reported the issue was given a custom jar with the new module and confirmed that they once again see the transactions that disappeared after they upgraded to Scala 2.13.

Instrumentation modules loaded/skipped

Supportability/WeaveInstrumentation/Loaded/com.newrelic.instrumentation.akka-http-2.13_10.1.8/1
Supportability/WeaveInstrumentation/Skipped/com.newrelic.instrumentation.akka-http-2.11_2.4.5/1

Classes being weaved by new module:

Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/directives/OnSuccessMagnet$
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/Directive$
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatcher$$anon$2
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatcher$$anon$1
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatcher$$anon$4
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatcher$$anon$3
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/Directives$
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/Route$
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatchers
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/RequestContextImpl
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatchers$$anon$14
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatcher
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatchers$PathEnd$
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatchers$$anon$15
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/ImplicitPathMatcherConstruction$$anon$13
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/ImplicitPathMatcherConstruction$$anon$12
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/ImplicitPathMatcherConstruction
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/marshalling/ToResponseMarshallable$$anon$1
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatchers$Segment$
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/com/agent/instrumentation/akka/http/PathMatcherScalaUtils$$anon$1
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatcher$
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/com/agent/instrumentation/akka/http/PathMatcherScalaUtils$$anon$2
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatcher$Matched
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatcher$$anon$5
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/marshalling/Marshal
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/server/PathMatchers$Slash$
Supportability/WeaveInstrumentation/WeaveClass/com.newrelic.instrumentation.akka-http-2.13_10.1.8/akka/http/scaladsl/marshalling/ToResponseMarshallable

jasonjkeller · 2021-04-08T18:51:35Z

instrumentation/akka-http-2.11_2.4.5/build.gradle

        compile("com.typesafe.akka:akka-stream_2.11:2.5.19")
    }
-    passesOnly('com.typesafe.akka:akka-http_2.12:[2.4.5,)') {


I removed the Scala 2.10 verifier checks from the old instrumentation module because there are no 2.10 compiled versions >= 2.4.5 on akka-http-experimental or akka-http thus they were never being verified against.

I also updated the start range for Scala 2.11 and 2.12 because 10.0.0 is the earliest version available, not 2.4.5.

jasonjkeller · 2021-04-08T18:52:11Z

instrumentation/akka-http-2.11_2.4.5/build.gradle

@@ -4,7 +4,7 @@ sourceSets.test.scala.srcDir "src/test/java"
 sourceSets.test.java.srcDirs = []

 jar {
-    manifest { attributes 'Implementation-Title': 'com.newrelic.instrumentation.akka-http-2.4.5' }
+    manifest { attributes 'Implementation-Title': 'com.newrelic.instrumentation.akka-http-2.11_2.4.5' }


Renamed the module to make the Scala version clear.

jasonjkeller · 2021-04-09T15:59:09Z

AITs pass except for the AkkaTest because of the renamed module. This PR on the AITs has been tested locally and fixes that failure.

XiXiaPdx

@jasonjkeller I believe you mentioned most of these files are the same as the previous instrumentation module and the big change was the scala version this module compiles against? Are there any instrumentation changes I should pay particular attention to?

I'm trying to focus my review on what you see as a significant change from the previous module.

jasonjkeller · 2021-04-13T18:36:01Z

@jasonjkeller I believe you mentioned most of these files are the same as the previous instrumentation module and the big change was the scala version this module compiles against? Are there any instrumentation changes I should pay particular attention to?

I'm trying to focus my review on what you see as a significant change from the previous module.

@XiXiaPdx The new module is virtually identical to the previous with the exception of a few minor Scala API changes that don't change how the instrumentation works at all.

…kka-http-2.13_2.4.5

XiXiaPdx

🚢

jack-berg and others added 6 commits February 2, 2021 14:01

fix infinite tracing race condition regarding span observer

f62fac7

point release 6.4.1

0a1ea01

update version

d63a60b

Add akka-http-2.13_2.4.5 inst module

3303b31

Rename akka-http-2.4.5 modules and fix verifier ranges

e84acf4

Merge branch 'main' into akka-http-2.13_2.4.5

504470d

jasonjkeller commented Apr 8, 2021

View reviewed changes

jasonjkeller added 3 commits April 9, 2021 13:56

Fix test by explicitly enabling postfix operator

fdf4d31

Fix another test with postfix op

89e7c8c

Cleanup

1b58524

XiXiaPdx reviewed Apr 12, 2021

View reviewed changes

jasonjkeller added 2 commits April 22, 2021 15:53

Fix instrumentation test

8c3ae8b

Merge branch 'main' of github.com:newrelic/newrelic-java-agent into a…

b2debbc

…kka-http-2.13_2.4.5

XiXiaPdx approved these changes May 3, 2021

View reviewed changes

jasonjkeller merged commit 3f9d53d into main May 3, 2021

jasonjkeller deleted the akka-http-2.13_2.4.5 branch May 3, 2021 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new akka-http-2.13_10.1.8 instrumentation module #271

Add new akka-http-2.13_10.1.8 instrumentation module #271

jasonjkeller commented Apr 8, 2021 •

edited

Loading

jasonjkeller Apr 8, 2021 •

edited

Loading

jasonjkeller Apr 8, 2021

jasonjkeller commented Apr 9, 2021

XiXiaPdx left a comment

jasonjkeller commented Apr 13, 2021

XiXiaPdx left a comment

Add new akka-http-2.13_10.1.8 instrumentation module #271

Add new akka-http-2.13_10.1.8 instrumentation module #271

Conversation

jasonjkeller commented Apr 8, 2021 • edited Loading

jasonjkeller Apr 8, 2021 • edited Loading

Choose a reason for hiding this comment

jasonjkeller Apr 8, 2021

Choose a reason for hiding this comment

jasonjkeller commented Apr 9, 2021

XiXiaPdx left a comment

Choose a reason for hiding this comment

jasonjkeller commented Apr 13, 2021

XiXiaPdx left a comment

Choose a reason for hiding this comment

jasonjkeller commented Apr 8, 2021 •

edited

Loading

jasonjkeller Apr 8, 2021 •

edited

Loading