Update http attrs #272
Closed
Update http attrs #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiao
commented
Apr 9, 2021
| @@ -63,6 +63,7 @@ private static void processResponse(URI requestURI, HttpResponse response) { | |||
| .uri(requestURI) | |||
| .procedure(PROCEDURE) | |||
| .inboundHeaders(inboundCatWrapper) | |||
| .status(response.getStatusLine().getStatusCode(), response.getStatusLine().getReasonPhrase()) | |||
There was a problem hiding this comment.
This is what every instrumentation will have to add.
The new method was added to the last interface of the step builder (Build).
So existing code can continue to call the build method, or add a call to the new status method and then call build.
meiao
commented
Apr 9, 2021
| * Set the status code/text of the HTTP response. | ||
| * @return the builder in a buildable state. | ||
| */ | ||
| Build status(Integer statusCode, String statusText); |
There was a problem hiding this comment.
This is another breaking change. But should only cause problems to someone implementing this interface.
Not sure why one would do it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds http status code/text to external spans and web transaction spans.
Related Github Issue
#225
Checks
Are your contributions backwards compatible with relevant frameworks and APIs?
Not entirely.
Does your code contain any breaking changes? Please describe.
Yes.
There is a change in the signature of one the HttpParameters constructors. The constructor is protected, so it would only affect people who subclassed HttpParameters. This can be avoided by creating a new constructor.
A method was added to the Build interface of the HttpParameters$Builder. This will only affect people that implemented that interface.
Does your code introduce any new dependencies? Please describe.
No.