Http4s blaze #363
Merged
Http4s blaze #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twcrone
reviewed
Aug 17, 2021
...rumentation/http4s-blaze-client-2.13_0.21/src/test/scala/com/nr/http4s/BlazeClientTest.scala
Outdated
Show resolved
Hide resolved
...rumentation/http4s-blaze-client-2.13_0.22/src/test/scala/com/nr/http4s/BlazeClientTest.scala
Outdated
Show resolved
Hide resolved
...p4s-blaze-server-2.12_0.21/src/main/scala/com/nr/instrumentation/http4s/RequestWrapper.scala
Show resolved
Hide resolved
newrelic-scala-zio-api/src/test/scala/com/newrelic/zio/api/TraceOpsDSLTest.scala
Outdated
Show resolved
Hide resolved
richard-gibson
force-pushed
the
http4s-blaze
branch
from
33a1d01
to
fe6ff95
Compare
richard-gibson
force-pushed
the
http4s-blaze
branch
from
fe6ff95
to
6e5c9f4
Compare
twcrone
approved these changes
Aug 19, 2021
|
Ran the new instrumentation tests and all functional tests successfully locally and did smoke test running against sample app provided by Richard. |
|
Also was able to run AITs against changes from this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
This PR adds Instrumentation for blaze client and server implementations of the HTTP4S library.
Related Github Issue
Testing
Testing carried out in separate AITs
Checks
[X] Are your contributions backwards compatible with relevant frameworks and APIs? Yes
[X] Does your code contain any breaking changes? No
[X] Does your code introduce any new dependencies? No