Add newrelic ssl certificate if ca_bundle_path is not specified. Reso… #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lic-java-agent into add_newrelic-com_ssl_cert
|
What if we pulled the cert as a built-time step? Does that help to reduce the maintenance burden? |
jasonjkeller
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The removal of nrcerts and use_private_ssl configuration in 6.0.0 is preventing applications with custom trust stores from connecting to New Relic. This change always adds the minimal *.newrelic.com SSL certificate needed to connect unless a specific ca_bundle_path is specified.