BlockingQueue and guard adding null #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbradellis
added
7.6.0
GTSE
tbradellis
force-pushed
the
statswork-npe
branch
from
7a3ac78
to
a5f1b51
Compare
meiao
reviewed
Feb 28, 2022
newrelic-agent/src/main/java/com/newrelic/agent/AsyncApiImpl.java
Outdated
Show resolved
Hide resolved
| ServiceFactory.getStatsService().doStatsWork( | ||
| StatsWorks.getRecordMetricWork(MessageFormat.format(MetricNames.SUPPORTABILITY_WEAVE_CLASS, | ||
| packageName, weaveResult.getClassName()), 1)); | ||
| StatsWorks.getRecordMetricWork(weaveClassStat, 1), weaveClassStat); |
There was a problem hiding this comment.
This change made the old code clearer.
newrelic-agent/src/main/java/com/newrelic/agent/jmx/LinkingMetadataRegistration.java
Outdated
Show resolved
Hide resolved
newrelic-agent/src/main/java/com/newrelic/agent/instrumentation/PointCutClassTransformer.java
Outdated
Show resolved
Hide resolved
newrelic-agent/src/main/java/com/newrelic/agent/service/ServiceManagerImpl.java
Outdated
Show resolved
Hide resolved
meiao
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for:
#621
We intermittently see NPEs from:
at com.newrelic.agent.stats.StatsServiceImpl.doStatsWork(StatsServiceImpl.java:61) ~[newrelic.jar:7.4.2]
at com.newrelic.agent.service.ServiceManagerImpl.replayStartupStatsWork(ServiceManagerImpl.java:585)
Which is preventing application startup with the agent.
They get the following error in newrelic.log when that happens.
We have been unable to replicate the issue. However there is general agreement that we can and should just guard against the NPE in that spot. It's also possible that another thread causes an issue.
This PR changes the List holding StatsWork to a LinkedBlockingQueue and guards against attempting to add a null to the queue (which would throw an NPE for LBQ). Logs that this occurred.
Checks