Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore SocketExceptions when attempting to connect to cloud providers #80

Merged
merged 2 commits into from
Oct 20, 2020
Merged

ignore SocketExceptions when attempting to connect to cloud providers #80

merged 2 commits into from
Oct 20, 2020

Conversation

tspring
Copy link
Contributor

@tspring tspring commented Oct 6, 2020

I noticed we'd log a SocketException when attempting to connect to AWS for cloud usage data

gfuller1
gfuller1 suggested changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@gfuller1 gfuller1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this specific exception? Looks like CloudUtilityTest already has a test for a different exception.

@gfuller1 gfuller1 merged commit c504efc into main Oct 20, 2020
@gfuller1 gfuller1 deleted the cloud_utility_fix branch October 20, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfuller1 gfuller1 gfuller1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tspring @gfuller1