Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalize the DOCKER_NATIVE_DRIVER_W_SYSTEMD regex to account for ot… #87

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Generalize the DOCKER_NATIVE_DRIVER_W_SYSTEMD regex to account for ot… #87

merged 2 commits into from
Oct 21, 2020

Conversation

tspring
Copy link
Contributor

@tspring tspring commented Oct 16, 2020

There can be more than one runtime. K8s with crio for example looks like this:
1:name=systemd:/system.slice/crio-67f98c9e6188f9c1818672a15dbe46237b6ee7e77f834d40d41c5fb3c2f84a2f.scope

gfuller1
gfuller1 suggested changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@gfuller1 gfuller1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this new case in DockerDataTest?

@tspring tspring requested a review from gfuller1 October 20, 2020 19:32
@tspring tspring merged commit d8ffd7d into main Oct 21, 2020
@tspring tspring deleted the crio_container_id branch October 21, 2020 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfuller1 gfuller1 Awaiting requested review from gfuller1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tspring @gfuller1