Fix httpurlconnection inst #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix-httpurlconnection-inst
…ix-httpurlconnection-inst
twcrone
approved these changes
Jun 24, 2022
|
Here's an example of one instrumented service service making an external call to another instrumented service using the
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
httpurlconnectioninstrumentation to use the newerreportAsExternaland distributed tracing APIs. The external call span now correctly is marked as external in distributed traces and contains the expectedhttp.*attributes.Fixes #387
The
externalAIT will pass once this PR is merged: https://github.com/newrelic/java-agent-integration-tests/pull/55