Skip to content
This repository has been archived by the owner on Jul 31, 2024. It is now read-only.

test: update versioned test helper to handle [email protected] changes #153

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

jmartin4563
Copy link
Contributor

Proposed Release Notes

Links

Details

Next.js 13.4.15 changed their startServer functionality to no longer return the server. Our versioned tests helpers were using that return value to shutdown the server in between runs. This change detects the new version and creates a simple shim that uses an event emitter to trigger next's internal cleanup functionality.

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #153 (6745f51) into main (7ec3d76) will decrease coverage by 9.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #153      +/-   ##
==========================================
- Coverage   92.69%   83.46%   -9.24%     
==========================================
  Files           4        4              
  Lines         260      260              
==========================================
- Hits          241      217      -24     
- Misses         19       43      +24     
Flag Coverage Δ
unit-tests-16.x 47.69% <ø> (ø)
unit-tests-18.x 47.69% <ø> (ø)
unit-tests-20.x 47.69% <ø> (ø)
versioned-tests-16.x 81.15% <ø> (-11.54%) ⬇️
versioned-tests-18.x 81.15% <ø> (-11.54%) ⬇️
versioned-tests-20.x 81.15% <ø> (-11.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mrickard mrickard self-assigned this Aug 14, 2023
@bizob2828 bizob2828 merged commit 3eb38cf into newrelic:main Aug 15, 2023
9 of 10 checks passed
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
bizob2828 added a commit to bizob2828/newrelic-node-nextjs that referenced this pull request Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants