Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds instrumentation for aiomcache #1173

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

jairhenrique
Copy link
Contributor

@jairhenrique jairhenrique commented Jun 28, 2024

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Adds support to aiomcache instrumentation.

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

@jairhenrique jairhenrique requested a review from a team June 28, 2024 16:50
@CLAassistant
Copy link

CLAassistant commented Jun 28, 2024

CLA assistant check
All committers have signed the CLA.

@jairhenrique jairhenrique force-pushed the aiomcache-support branch 3 times, most recently from 475342f to 4e0b01f Compare July 1, 2024 21:04
@mergify mergify bot added the tests-failing label Jul 1, 2024
@jairhenrique
Copy link
Contributor Author

@TimPansino @lrafeei I tried to replicate the bmcache tests, but I couldn't understand why the tests are failing. Can you guide me?

@lrafeei
Copy link
Contributor

lrafeei commented Jul 3, 2024

Hello @jairhenrique --Thanks for the submission! As for the test failures, it’s just a typo causing the issue. In lines 53 and 91 in tests/datastore_aiomemcache/test_aiomemcache.py, the expected transaction metric is set to test_aiomcache:test_... and the filename is test_aiomemcache.py—to stay consistent, let’s change the filename to test_aiomcache.py

@jairhenrique
Copy link
Contributor Author

@lrafeei thanks!! I ran the tests locally and they now pass!

@mergify mergify bot removed the tests-failing label Jul 3, 2024
@lrafeei lrafeei merged commit 5a3431f into newrelic:main Jul 3, 2024
47 of 49 checks passed
@jairhenrique jairhenrique deleted the aiomcache-support branch July 3, 2024 20:32
@hmstepanek hmstepanek added this to the v9.12.0 milestone Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants